nextui icon indicating copy to clipboard operation
nextui copied to clipboard

fix: changed breakpoint to md #2629

Open ShrinidhiUpadhyaya opened this issue 1 year ago • 4 comments

Closes #2629

📝 Description

  • The signup button in Navbar with menu is getting clipped in stories.
  • The breakpoint of Navbar with Menu is md while the breakpoint for other Navbars (Sticky, Static, Hide on Scroll) is sm

⛳️ Current behavior (updates)

  • The Sign up button is getting clipped when you resize the window at a specific point.

  • The breakpoints are different when compared to other Navbars.

🚀 New behavior

Now the Sign Up button is not getting clipped and consistent behaviour is maintained across Navbars(Sticky, Static, Hide on Scroll, With Menu)

NavbarBugFix

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

  • Style
    • Improved responsiveness of the Navbar for better visibility across various screen sizes.

ShrinidhiUpadhyaya avatar Apr 02 '24 09:04 ShrinidhiUpadhyaya

⚠️ No Changeset found

Latest commit: aeeb83c6ed23bfe7c9ba1b2b0defd9edcd5826e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Apr 02 '24 09:04 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 9:18am

vercel[bot] avatar Apr 02 '24 09:04 vercel[bot]

Someone is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 02 '24 09:04 vercel[bot]

Walkthrough

The change primarily addresses an issue where the signup button in the Navbar with Menu was getting clipped at certain screen sizes. By adjusting the breakpoint from sm to md, the Navbar's visibility behavior aligns better across different devices, ensuring consistency and improving the user interface.

Changes

File Path Change Summary
.../navbar/stories/navbar.stories.tsx Modified class name from hidden sm:flex to hidden md:flex in NavbarContent

Assessment against linked issues

Objective Addressed Explanation
Signup Button is getting clipped in Navbar with Menu (#2629)
Inconsistent Navbar display breakpoint between Navbar types (#2629)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Apr 02 '24 09:04 coderabbitai[bot]