nextui icon indicating copy to clipboard operation
nextui copied to clipboard

fix(input): resolve RTL support (#2315)

Open mrbadri opened this issue 1 year ago โ€ข 5 comments

Closes # 2315

๐Ÿ“ Description

Add RTL support to the input component.

โ›ณ๏ธ Current behavior (updates)

The input component currently lacks support for right-to-left (RTL) direction.

๐Ÿš€ New behavior

This PR addresses the RTL support issue in the input component, ensuring correct rendering in RTL environments.

๐Ÿ’ฃ Is this a breaking change (Yes/No):

๐Ÿ“ Additional Information

  • Resolves issue #2315
  • Added RTL support to the input component

mrbadri avatar Feb 05 '24 18:02 mrbadri

๐Ÿฆ‹ Changeset detected

Latest commit: fab4f9e5a1f45337fd58a0b4a683a6040716a6e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@nextui-org/input Patch
@nextui-org/autocomplete Patch
@nextui-org/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Feb 05 '24 18:02 changeset-bot[bot]

@mrbadri is attempting to deploy a commit to the NextUI Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Feb 05 '24 18:02 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
nextui-storybook-v2 โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Mar 7, 2024 10:20pm

vercel[bot] avatar Feb 05 '24 18:02 vercel[bot]

Hi @mrbadri, thank you for submitting this pull request. I will review it shortly

jrgarciadev avatar Feb 08 '24 13:02 jrgarciadev

@mrbadri it worked fine, thank you!, could you please add the changeset?

jrgarciadev avatar Feb 13 '24 00:02 jrgarciadev

Hi jrgarciadev, thank you for review my pull request

when i run 'pnpm changeset' i get this error : ๐Ÿฆ‹ Which packages would you like to include? ยท No items were selected ๐Ÿฆ‹ error You must select at least one package to release ๐Ÿฆ‹ error (You most likely hit enter instead of space!)

i can't add changeset

mrbadri avatar Feb 18 '24 20:02 mrbadri

Hi jrgarciadev, I add changeset

mrbadri avatar Feb 21 '24 09:02 mrbadri

Hi Mohammad Reza! if you need any help with RTL support, I'm ready to help you.

itmysm avatar Mar 04 '24 08:03 itmysm

Hi jrgarciadev,

I hope you're doing well! I've made some updates to address the feedback you provided earlier. Could you please take another look at my pull request when you have a moment? Your feedback is greatly appreciated.

Thank you!

Mohammad Reza Badri

mrbadri avatar Mar 08 '24 09:03 mrbadri