nextui icon indicating copy to clipboard operation
nextui copied to clipboard

fix(input): support both endContent and isClearable at the same time

Open kght6123 opened this issue 1 year ago β€’ 6 comments

  • closes: #2254
  • closes: #2145

πŸ“ Description

Improved UI when both endContent and isClearable are specified.

⛳️ Current behavior (updates)

endContent replaces the Clear button.

πŸš€ New behavior

Both endContent and Clear buttons are visible.

πŸ’£ Is this a breaking change (Yes/No):

No.

Currently, both endContent and isClearable do not work as desired. It's confusing that endContent is replaced by a Clear button, and I don't think there's any use for it.

πŸ“ Additional Information

γ‚Ήγ‚―γƒͺγƒΌγƒ³γ‚·γƒ§γƒƒγƒˆ 2024-02-02 0 04 17

γ‚Ήγ‚―γƒͺγƒΌγƒ³γ‚·γƒ§γƒƒγƒˆ 2024-02-02 0 04 45

Summary by CodeRabbit

  • New Features

    • Enhanced input component to display both Clear button and end content simultaneously for improved user experience.
    • Introduced dynamic styling for the clear button based on the width of end content.
    • Added a new story for the input component showcasing clearable functionality with visual enhancements.
  • Bug Fixes

    • Improved responsiveness and visual consistency of the input component, particularly when clearable.

kght6123 avatar Feb 01 '24 15:02 kght6123

πŸ¦‹ Changeset detected

Latest commit: 9aa18da77fcb1b5d5c549dd70606c4dde6e8155c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@nextui-org/input Minor
@nextui-org/autocomplete Patch
@nextui-org/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Feb 01 '24 15:02 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
nextui-storybook-v2 βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Mar 6, 2024 2:49pm

vercel[bot] avatar Feb 01 '24 15:02 vercel[bot]

@kght6123 is attempting to deploy a commit to the NextUI Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Feb 01 '24 15:02 vercel[bot]

Hi @kght6123, thank you for submitting this pull request (PR). I will review it shortly

jrgarciadev avatar Feb 08 '24 13:02 jrgarciadev