nextui icon indicating copy to clipboard operation
nextui copied to clipboard

fix(components): accordion component throws "validateDOMNesting" erro…

Open kuri-sun opened this issue 1 year ago • 6 comments

Closes #2168

📝 Description

The accordion component throws a "validateDOMNesting" error on the storybook

⛳️ Current behavior (updates)

When you open up the Accordion component(Custom with classNames) on the storyboard, you will get an error console message that says "validateDOMNesting(...) cannot appear as a descendant of p".(the pic below) error

🚀 New behavior

There are no errors in the console.

💣 Is this a breaking change (Yes/No):

No.

📝 Additional Information

kuri-sun avatar Dec 26 '23 01:12 kuri-sun

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2024 10:38pm

vercel[bot] avatar Dec 26 '23 01:12 vercel[bot]

⚠️ No Changeset found

Latest commit: db21edfa5465ed395e8531e0ced56280b322f9ae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Dec 26 '23 01:12 changeset-bot[bot]

@kuri-sun is attempting to deploy a commit to the NextUI Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Dec 26 '23 01:12 vercel[bot]

@kuri-sun sorry, could you please modify this component code as well? https://nextui.org/docs/components/accordion#start-content

jrgarciadev avatar Feb 08 '24 18:02 jrgarciadev

@jrgarciadev Absolutely

kuri-sun avatar Feb 08 '24 22:02 kuri-sun

@jrgarciadev The requested change was modified. Thank you! 😄

kuri-sun avatar Feb 13 '24 02:02 kuri-sun

@kuri-sun could you please update this as well? https://vscode.dev/github/nextui-org/nextui/blob/main/apps/docs/content/components/accordion/custom-styles.ts#L217

jrgarciadev avatar Mar 03 '24 21:03 jrgarciadev

@junior Of course, immediately!

kuri-sun avatar Mar 03 '24 22:03 kuri-sun