nextui icon indicating copy to clipboard operation
nextui copied to clipboard
verified publisher icon nextui-org

fix(navbar): fixed the height of navbar menu

Open nozomemein opened this issue 2 years ago β€’ 5 comments

πŸ“ Description

Modify the Navbar Menu modal styling when it's open.

⛳️ Current behavior (updates)

There's a slight gap between the bottom of the modal and the page. Content behind the modal is visible through the gap.

πŸš€ New behavior

before after
γ‚Ήγ‚―γƒͺγƒΌγƒ³γ‚·γƒ§γƒƒγƒˆ 2023-10-25 12 50 13 γ‚Ήγ‚―γƒͺγƒΌγƒ³γ‚·γƒ§γƒƒγƒˆ 2023-10-25 12 49 47

πŸ’£ Is this a breaking change (Yes/No):

No

πŸ“ Additional Information

Nothing specialπŸ‘

nozomemein avatar Oct 25 '23 03:10 nozomemein

⚠️ No Changeset found

Latest commit: 5202540ca5b7a658fb89434e5b6edc35aa975f96

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 25 '23 03:10 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
nextui-storybook-v2 βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback May 26, 2024 0:15am

vercel[bot] avatar Oct 25 '23 03:10 vercel[bot]

@nozomemein is attempting to deploy a commit to the NextUI Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 25 '23 03:10 vercel[bot]

Any update on this PR ? Right now I'm fixing it inside my own code, but would be great to have it fixed

RibeyrollesMatthieu avatar Nov 24 '23 10:11 RibeyrollesMatthieu

@nozomemein Sorry for the delayed review, and thank you for the PR. Can you confirm if this behavior is still present in the latest version? If it is, it would be helpful to have a link to the site where it's occurring.

ryo-manba avatar May 07 '24 14:05 ryo-manba

@ryo-manba Thanks for the reply!! As of today, the bug still exists in the NextUI component page.

Screenshot below.

γ‚Ήγ‚―γƒͺγƒΌγƒ³γ‚·γƒ§γƒƒγƒˆ 2024-05-18 20 41 21

This bug was also reported in this issue.

  • https://github.com/nextui-org/nextui/issues/2766

nozomemein avatar May 18 '24 11:05 nozomemein

[!WARNING]

Rate Limit Exceeded

@nozomemein has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 46 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between a48bd6a79de4740f3e8ca166c32b473e57a55f04 and 5202540ca5b7a658fb89434e5b6edc35aa975f96.

Walkthrough

The recent refinements involve adjusting height calculations for the navbar and its menu transitions to ensure a precise fit within the viewport. These changes enhance visual consistency and behavior, removing unnecessary subtractions and fixing typos for an improved user experience.

Changes

Files Change Summary
.../navbar-menu-transitions.ts, .../theme/src/components/navbar.ts Adjusted height calculations for the navbar and menu transitions, removing unnecessary subtractions and fixing typos.

In the world of code, a change so slight,
A missing pixel, now set right.
The navbar stands both tall and true,
With heights adjusted, fresh and new.
A rabbit’s joy in lines refined,
Celebrates the code aligned.
🌟✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar May 25 '24 03:05 coderabbitai[bot]