ncov icon indicating copy to clipboard operation
ncov copied to clipboard

#463 Check if subsampling rule is supported and raise a meaningful error if it is not

Open emontag47 opened this issue 3 years ago • 0 comments

Description of proposed changes

What is the goal of this pull request? What does this pull request change? This attempts to fix issue 463 and check if the user inputted subsampling rules are supported and raises a meaningful error that lists the supported subsampling schemes if not.

Related issue(s)

Fixes # Related to #463

Testing

What steps should be taken to test the changes you've proposed? Test to see if, when an unsupported subsampling rule is inputted, the system raises a meaningful error that also displays the supported subsampling rules the user can chose from.

If you added or changed behavior in the codebase, did you update the tests, or do you need help with this? Yes, my partner and I changed the codebase but did not updated the tests. We would need help with this.

Release checklist

If this pull request introduces backward incompatible changes, complete the following steps for a new release of the workflow:

  • [ ] Determine the version number for the new release by incrementing the most recent release (e.g., "v2" from "v1").
  • [ ] Update docs/src/reference/change_log.md in this pull request to document these changes and the new version number.
  • [ ] After merging, create a new GitHub release with the new version number as the tag and release title.

If this pull request introduces new features, complete the following steps:

  • [ ] Update docs/src/reference/change_log.md in this pull request to document these changes by the date they were added.

emontag47 avatar Dec 15 '21 01:12 emontag47