augur icon indicating copy to clipboard operation
augur copied to clipboard

Also accept "region" as synonym of "source" for gb files?

Open corneliusroemer opened this issue 1 year ago • 1 comments

Context

I've been hitting a bug with Augur >=24 on a preexisting workflow that used a genbank file that uses "region" in place of "source".

This PR started requiring specifically source: #1351 - and I never traced down while I got the failure. I didn't understand at first what was happening. In retrospect it would have been helpful to have the error mention that this breaking change occurs since v24

Description

I don't know much about genbank files in the wild, so maybe this usage of region instead of source was an idiosyncracy of my gb file (I don't know where I got it from) - but in case that others use region instead of source, it might make sense to treat region as a synonym of source? At least in my case, the two contain equivalent information:

corneliusroemer avatar Sep 25 '24 14:09 corneliusroemer

In retrospect it would have been helpful to have the error mention that this breaking change occurs since v24

Do you mean the error thrown at runtime? The changelog mentioned this as a major change:

ancestral, translate: GenBank files now require the (GFF mandatory) source feature to be present.[#1351][] (@jameshadfield)

GFFs are rather varied in the wild - I tried to add in helpful runtime errors when unexpected cases are encountered, but we could always do with more!

jameshadfield avatar Sep 25 '24 20:09 jameshadfield