augur icon indicating copy to clipboard operation
augur copied to clipboard

DOC/DEV: test `bash tests/builds/runner.sh` not mentioned in dev docs

Open corneliusroemer opened this issue 1 year ago • 1 comments

There seems to be a test that is only run in CI but missing from the dev documentation.

It'd be great if the person who added the line to the CI config - run: bash tests/builds/runner.sh could explain how to do this locally and what is being tested. I think it was @victorlin.

Thanks!

I think it was in commit 092879ba454cc31e8f06c975340ad199ece08f50

Example where this test fails and I don't immediately understand why: https://github.com/nextstrain/augur/runs/7766923240?check_suite_focus=true#step:11:258

corneliusroemer avatar Aug 10 '22 13:08 corneliusroemer

tests/builds/runner.sh was added in 2710dbceac4ca433d86567d7995a1c9687eb797a by @jameshadfield to the Travis CI config.

It was first mentioned in DEV_DOCS.md in e17be15 by @huddlej and then subsequently reworked in 0878320 and 070c6a7.

Its invocation was migrated from Travis CI → GitHub Actions in 092879b by @victorlin, as you noted.

It was (incidentally?) removed from DEV_DOCS.md in f1ae13e by @victorlin as part of other changes.

tsibley avatar Aug 22 '22 21:08 tsibley