clojure-mode icon indicating copy to clipboard operation
clojure-mode copied to clipboard

Make keybindings more Windows/Linux sensible

Open coconutpalm opened this issue 4 years ago • 4 comments

Ctrl+left/right moves by word on Win/Lin. This fixes the Windows/Linux keybindings to respect this.

Also, Shift+Alt+up/down grows/shrinks the selection in Eclipse and the prior default was so close to this I thought it worth making it the same for people who already have this muscle-memory.

coconutpalm avatar Oct 14 '21 01:10 coconutpalm

Thanks for the PR! I think the wordwise movement makes sense but since im on macOS I can't really say. @leahneukirchen could you chime in here?

Making grow/shrink selection more like Eclipse is something I feel less good about as it complicates the shortcut and I'm not sure how many Clojurians use Eclipse. You're the first one I hear about Clojure + Eclipse from.

mk avatar Oct 25 '21 18:10 mk

Thanks for the PR! I think the wordwise movement makes sense but since im on macOS I can't really say. @leahneukirchen could you chime in here?

Thanks!

Making grow/shrink selection more like Eclipse is something I feel less good about as it complicates the shortcut and I'm not sure how many Clojurians use Eclipse. You're the first one I hear about Clojure + Eclipse from.

I'm okay with other alternatives, but if we're already close to Eclipse's implementation it makes sense to me just to use that--to avoid confusion for those with Eclipse muscle-memory.

coconutpalm avatar Dec 29 '21 22:12 coconutpalm

Ctrl+Left/Right is indeed used by default in Gtk, Emacs, Vim.

leahneukirchen avatar Jul 06 '22 09:07 leahneukirchen

Ctrl+left/right for movement makes sense to me. I don't have any strong opinions about the keybinding for growing/shrinking the selection. I don't think Eclipse is a good reason for changing the keybindings, though one could argue that it makes sense to add Shift as a modifier, because you adjust the selection (which is usually done using shift+movement).

Sohalt avatar Jul 06 '22 09:07 Sohalt