connect icon indicating copy to clipboard operation
connect copied to clipboard

[IDEA] com.mirth.connect.donkey.server.data.DonkeyDao should extend Closeable

Open jonbartels opened this issue 3 years ago • 0 comments

Is your feature request related to a problem? Please describe. I was using a DonkeyDao object and wanted to close it using IOUtils.closeQuietly. That operation failed because even though DonkeyDao defines void close() it doesn't extend Closeable. https://docs.oracle.com/javase/7/docs/api/java/io/Closeable.html

Describe your use case I want Closeable things to implement the Closeable interface.

Describe the solution you'd like public interface DonkeyDao extends Closeable

Describe alternatives you've considered We just call DonkeyDao.close() which has very similar logic as IOUtils.closeQuietly.

jonbartels avatar Jan 12 '22 20:01 jonbartels