training
training copied to clipboard
nextflow-io
fixes to hello-nextflow after recent updates
Recent updates made some changes that were not entirely followed through in the nf-test part of hello-nextflow. This PR fixes that. Also, I updated the nf-test outputs to reflect the version used in the gitpod environement.
Feel free not to merge since @vdauwera will likely add similar fixes, but I would like to have the PR open until after the 5th of November, so I can use the build from this PR as page to use in my Nextflow training that will come up.
PS: Sorry about all the commits :/
Deploy Preview for nextflow-training ready!
| Name | Link |
|---|---|
| Latest commit | c066b3863b8c2c564c9ab8cf8ecebd7fbbf97fc8 |
| Latest deploy log | https://app.netlify.com/sites/nextflow-training/deploys/67121c42e2688500088e3d67 |
| Deploy Preview | https://deploy-preview-401--nextflow-training.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thanks Fran! Coincidentally I opened https://github.com/nextflow-io/training/pull/400 around the same time you did, it looks like we both caught a few different things. I'll see if I can cherry-pick the bits you updated that I didn't; we're teaching it today so I'm very keen to get the fixes in.
That being said we definitely can keep your PR open until your training so you can feel confident everything is working the way you expect. I have another PR with bigger changes to the GATK training module, which you may prefer not to take on at the last minute. Though it will have a lot more explanations for what's going on at the various steps, which may be of interest to you. I'm aiming to finalize that over the weekend since we'll be teaching it at the Summit.
Confirming we've addressed all the issues you picked up. Note that we've made significant updates in the meantime. Happy to give you a rundown in case you want to switch to the newer version for your training.
@FranBonath Do you mind if we close this now that we've moved on to v2 of Hello Nextflow?