nextflow icon indicating copy to clipboard operation
nextflow copied to clipboard

Azure Batch validates the region before checking available VMs

Open adamrtalbot opened this issue 1 year ago • 3 comments

If the Azure region was invalid (i.e. useast vs eastus) Nextflow would still check for regions. This PR checks for the existence of a region before checking for available VMs.

Additions:

  • Nextflow checks for a valid region before checking the available VMs.
  • This adds some very verbose logging which helps in debugging but might be too much.

TODO: ~- Confirm this will work with an unlisted region, allowing users to manually configure a pool in a region if the Nextflow set of regions is out of date.~ I've confirmed this works with an unlisted region by deleting the eastus entry demonstrating that Nextflow raises a warning into the console:

N E X T F L O W  ~  version 24.05.0-edge
Launching `https://github.com/nextflow-io/hello` [cheeky_hugle] DSL2 - revision: 7588c46ffe [master]
WARN: [AZURE BATCH] No location called eastus found! Please confirm it exists and the name is correct!
[fb/b8674b] Submitted process > sayHello (3)
[e1/275573] Submitted process > sayHello (1)
[5f/7bf8d5] Submitted process > sayHello (4)
[ad/1f8280] Submitted process > sayHello (2)

adamrtalbot avatar Jul 03 '24 10:07 adamrtalbot

Deploy Preview for nextflow-docs-staging canceled.

Name Link
Latest commit 722223322959c7af933db535e873228e0b84b803
Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/67d7ed87c5050e00088685ed

netlify[bot] avatar Jul 03 '24 10:07 netlify[bot]

Moving to draft because lacks of tests

pditommaso avatar Jul 08 '24 13:07 pditommaso

Moving to draft because lacks of tests

Good point because I missed something: https://github.com/nextflow-io/nextflow/pull/5108/commits/bd60be373b519accb3d07df7b1c3f1b7033daef2

adamrtalbot avatar Jul 08 '24 16:07 adamrtalbot

@adamrtalbot there are some conflicts I'm not able to solve

pditommaso avatar Mar 15 '25 11:03 pditommaso

done: 7022b64ecb249349601d76f994d1cf5738b14a39

adamrtalbot avatar Mar 16 '25 08:03 adamrtalbot

@adamrtalbot consider creating future PRs directly in this repo instead of your own fork, otherwise cloud tests are not executed

pditommaso avatar Mar 17 '25 10:03 pditommaso

@adamrtalbot I've removed the log of vm list because it's huge 👉 67ffc8ab

pditommaso avatar Mar 19 '25 08:03 pditommaso