nextflow icon indicating copy to clipboard operation
nextflow copied to clipboard

Add docs for process.cleanup

Open abhi18av opened this issue 2 years ago • 8 comments

Following up from the discussion earlier today.

abhi18av avatar Oct 27 '21 11:10 abhi18av

@pditommaso perhaps we can merge this in the docs?

abhi18av avatar Feb 11 '22 06:02 abhi18av

@abhi18av Can you put this cleanup directive in alphabetical order of the directives list so that it is easier for people to find?

bentsherman avatar Feb 11 '22 13:02 bentsherman

Good point @bentsherman, I've now fixed the ordering of c* directives.

abhi18av avatar Feb 11 '22 17:02 abhi18av

@bentsherman , mind if I point this PR to your https://github.com/nextflow-io/nextflow/pull/2698 ?

abhi18av avatar Mar 07 '22 15:03 abhi18av

I was just gonna wait for this PR to be merged first 😄

bentsherman avatar Mar 07 '22 16:03 bentsherman

Aah, okay 😅

Well, I don't have merge rights so pinging @pditommaso to do the honors.

abhi18av avatar Mar 07 '22 16:03 abhi18av

Never wanted to document this, because the logic is a bit convoluted and it can create false expectations. Also, note it's enabled by default

https://github.com/nextflow-io/nextflow/blob/6930408ba1dba6e70ddcf76fa713d2533a007af5/modules/nextflow/src/main/groovy/nextflow/executor/BashWrapperBuilder.groovy#L445-L448

pditommaso avatar Mar 07 '22 17:03 pditommaso

Never wanted to document this, because the logic is a bit convoluted and it can create false expectations.

I kind of agree on this, the name cleanup is now at top level config as well as in the process config so it might be misleading.

In any case, if there's still interest in this PR then I'll test some assumptions to improve the docs on the SLURM cluster once we have it up and running internally.

Otherwise, please feel free to close this PR 👍

abhi18av avatar Mar 23 '22 09:03 abhi18av

This feature never has never been considered satisfactory. Think it's better to keep undocumented.

pditommaso avatar Nov 29 '22 17:11 pditommaso