workflow_script icon indicating copy to clipboard operation
workflow_script copied to clipboard

Fix broken link to image in README.md

Open belonesox opened this issue 2 years ago • 4 comments

belonesox avatar Nov 22 '23 01:11 belonesox

Indeed your fix would fix the path.

Actually it is a wrong screenshot thought, and refers only to that one already shown on top of the read me. Once upon a time, this screenshot was being used there: https://github.com/nextcloud/workflow_script/blob/ee8753ffa59ff0bd5842692160267d5be094f660/screenshots/example_rule.png

@belonesox do you fancy to take a new, up to date one and place it there?

blizzz avatar Nov 22 '23 08:11 blizzz

Hmm... I can, but screenshot for my example workflow (I spent several hours, debugging generation of PDF from xournal, what placeholders substitutes is not obvious), and I cannot reproduce the example workflow with «style and students». Actually, placeholder for root data (like /var/data/xournalpp) directory looks missing, and I have to hardcore it.

Should I describe the whole my case (and how to debug problems?)

belonesox avatar Nov 22 '23 12:11 belonesox

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

github-actions[bot] avatar Dec 06 '23 02:12 github-actions[bot]

@belonesox Sorry, this went under :disappointed:

It is not necessary to replicate the example with style, any other does as well.

Actually, placeholder for root data (like /var/data/xournalpp) directory looks missing, and I have to hardcore it.

If a place holder for the data dir is necessary, such can be added. Should not be a big issue I think, can be taken straight from the config. That would go into a separate PR though :)

blizzz avatar Jan 15 '24 17:01 blizzz