viewer icon indicating copy to clipboard operation
viewer copied to clipboard

Deleting current file too easy

Open wiswedel opened this issue 4 years ago • 3 comments

Is your feature request related to a problem? Please describe. Since the implementation of https://github.com/nextcloud/viewer/pull/619, it is too easy to accidentally click the trash can rather than the close-X when attempting to close the current file.

image

Consequence: If you accidentally click the trash icon, the viewer closes and the file gets deleted without confirmation. The file listing you get back to however won't be refreshed instantly so you still see the file you just accidentally deleted - which makes the accidental deletion even more fatal since you don't even know you deleted something.

Describe the solution you'd like Allow deletion only after two steps: If a general deletion confirmation popup isn't possible since it wouldn't align with the general UI behavior, at least put the button behind the ... menu, regardless of the sidebar already being opened. That way you have like a safety cover over the missile switch: image

Additional context The trash icon is only that easily accessible when the sidebar is opened. However, the deletion without confirmation remains.

wiswedel avatar Jan 15 '21 15:01 wiswedel

cc @skjnldsv

wiswedel avatar Jan 22 '21 18:01 wiswedel

For me the new implementation is fine. See comments in https://github.com/nextcloud/viewer/issues/483 There is always the recycle bin as a parachute 🪂 .

rakekniven avatar Feb 18 '21 14:02 rakekniven

@jancborchardt

skjnldsv avatar Feb 18 '21 15:02 skjnldsv

This is fixed in the meantine

szaimen avatar Mar 07 '23 17:03 szaimen