viewer icon indicating copy to clipboard operation
viewer copied to clipboard

[stable30] fix: Hide download action when file does not provide download permissions

Open backportbot[bot] opened this issue 1 year ago • 10 comments

Backport of #2482

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • [x] Review and resolve any conflicts
  • [x] Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

backportbot[bot] avatar Sep 15 '24 10:09 backportbot[bot]

@skjnldsv can we merge this, please? :pray:

Koc avatar Nov 14 '24 15:11 Koc

I've tested it, it works in general. The only one thing - we should update import in Viewer.vue: import { canDownload } from '../utils/canDownload.ts'

Koc avatar Dec 10 '24 17:12 Koc

/compile amend /

skjnldsv avatar Jan 28 '25 13:01 skjnldsv

@susnux mind fixing the conflicts ?

skjnldsv avatar Jan 28 '25 13:01 skjnldsv

Any chance this lands on the next RC? Thanks 🙏

solracsf avatar Mar 05 '25 06:03 solracsf

Sorry @solracsf , got overloaded with requests and missed that one :(

skjnldsv avatar Mar 07 '25 08:03 skjnldsv

Files are missing and other conflicts @susnux

skjnldsv avatar Mar 07 '25 08:03 skjnldsv

Files are missing and other conflicts

should be fixed

susnux avatar Apr 29 '25 11:04 susnux

/compile

AndyScherzinger avatar Jul 03 '25 12:07 AndyScherzinger

This looks like a server issue

  1. The init script is NOT added on public pages
  2. Even after it is, the nc:share-attributes is empty. image

skjnldsv avatar Jul 03 '25 15:07 skjnldsv