viewer icon indicating copy to clipboard operation
viewer copied to clipboard

Background transparency

Open setnes opened this issue 5 years ago • 13 comments

Is your feature request related to a problem? Please describe. I would like to be able to eliminate the transparency and use a black background. Seeing other files listed behind an image takes away from the image viewing experience. All emphasis should be on the photo, not other NextCloud files.

Describe the solution you'd like I would like a configuration option to set the viewer transparency percentage. If that's not possible, I'd like to just have a black background instead of a transparent one.

Describe alternatives you've considered The only alternative I have found is to disable this viewer and use the gallery viewer for photos. This might not be an option in the future depending on if the gallery app is changed to use this viewer instead of it's own.

setnes avatar Sep 13 '19 18:09 setnes

Hey! Thanks for your report! We aim to simplicity and don't want to add options for such variations of the software. I feel like the current background is pretty ok to me, but maybe you think we should darken it a bit. Can you provide an example of opacity that would fit your need?

cc @jancborchardt :)

skjnldsv avatar Sep 13 '19 20:09 skjnldsv

Currently it’s at rgba(0,0,0,0.92), how about we try with rgba(0,0,0,0.97) for some time?

It’s much darker, but still gives a slight bit of context.

jancborchardt avatar Sep 13 '19 21:09 jancborchardt

Why does it have to be transparent at all? The only thing that should be visible is the photo/video/etc being viewed. Everything else is a distraction.

setnes avatar Sep 13 '19 21:09 setnes

Maybe the background should be 100% black when the photo is viewed full screen and the transparency could be kept when not in full screen mode... just an idea.

setnes avatar Sep 13 '19 21:09 setnes

Yeah, I'm also fine with it being fully black.

@skjnldsv @juliushaertl I guess having it slightly transparent is another thing that is special for the first run wizard. And there it should also be more transparent than .92 opacity.

jancborchardt avatar Sep 14 '19 06:09 jancborchardt

Didn't we have 0.97 in the beginning and we decreased it because the context of the files app was totally missing?

juliusknorr avatar Sep 14 '19 07:09 juliusknorr

Didn't we have 0.97 in the beginning and we decreased it because the context of the files app was totally missing?

It's the other way around, it was too light, and we increased it twice: https://github.com/nextcloud/nextcloud-vue/pull/300

.7 => .85 => .92

skjnldsv avatar Sep 14 '19 08:09 skjnldsv

Yup, most of the changes are because we used the viewer for the first run wizard initially, and only then for pictures.

  • First run wizard needs the context
  • Pictures should be focused

So they actually have slightly different requirements. :)

jancborchardt avatar Sep 14 '19 16:09 jancborchardt

@jancborchardt then I'll let you decide :)

skjnldsv avatar Sep 14 '19 21:09 skjnldsv

Hehe, then let’s do:

  • full black for the Viewer background, no transparency
  • the current .92 value for First run wizard

From there we can still see if we need to adjust anything. But the important thing is we separate these 2 distinct cases.

jancborchardt avatar Sep 15 '19 19:09 jancborchardt

What would be the default modal component value?

skjnldsv avatar Sep 16 '19 08:09 skjnldsv

Let’s use the same as first run wizard for now? We could maybe also then move the first run wizard / default value down again to a previous value of .85 or .7?

And then we have special cases for:

  • Viewer (cause you need focus and background should be dark)
  • Text (cause you need focus and background by default is white)

jancborchardt avatar Sep 16 '19 15:09 jancborchardt

Btw https://github.com/nextcloud/nextcloud-vue/blob/ccd42cc97c21dfa9d9d8f4ac0363b8833c26b7df/src/components/Modal/Modal.vue#L489

What shall we do? It isn't that bad in the end? @jancborchardt

skjnldsv avatar Aug 24 '20 13:08 skjnldsv