viewer icon indicating copy to clipboard operation
viewer copied to clipboard

Update Videos.vue

Open sptcguy opened this issue 1 year ago • 3 comments

Remove video{ max-height } attribute.

This fixes https://github.com/nextcloud/viewer/issues/1831

sptcguy avatar Jul 08 '24 04:07 sptcguy

@hamza221 seems like you changed that line to fix full screen on iOS: https://github.com/nextcloud/viewer/pull/1819 Could you two ensure there is no regression from this change?

artonge avatar Jul 08 '24 14:07 artonge

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

github-actions[bot] avatar Jul 23 '24 02:07 github-actions[bot]

@hamza221 seems like you changed that line to fix full screen on iOS: #1819 Could you two ensure there is no regression from this change?

@hamza221 any news?

skjnldsv avatar Sep 13 '24 12:09 skjnldsv

Hi, is there any update on this ?

tzerber avatar Mar 25 '25 09:03 tzerber

Thank you for the pull request, we fixed it with this now:

https://github.com/nextcloud/viewer/pull/2954

susnux avatar Sep 01 '25 23:09 susnux