viewer icon indicating copy to clipboard operation
viewer copied to clipboard

Standardize full screen mode for viewer integrations

Open juliushaertl opened this issue 2 years ago • 1 comments

Collabora and Text use a bit of a hacky approach to make the viewer show their content full screen with the special case that for Collabora the viewer header is actually hidden and the close/sidebar buttons are actually rendered by Collabora.

With https://github.com/nextcloud/viewer/pull/1229 that basically caused some regressions on the Text and Collabora side. To avoid that it would be good to have some indicator on the apps viewer integration that the modal content should span full width and height.

This could be handled similarly to https://github.com/nextcloud/viewer/pull/1051 to be an additional option on the handler registration.

Any objections @skjnldsv ?

juliushaertl avatar May 17 '22 13:05 juliushaertl

Collabora and Text use a bit of a hacky approach to make the viewer show their content full screen with the special case that for Collabora the viewer header is actually hidden and the close/sidebar buttons are actually rendered by Collabora.

With #1229 that basically caused some regressions on the Text and Collabora side. To avoid that it would be good to have some indicator on the apps viewer integration that the modal content should span full width and height.

This could be handled similarly to #1051 to be an additional option on the handler registration.

Any objections @skjnldsv ?

None, pdf viewer would also love this :)

skjnldsv avatar Jun 03 '22 08:06 skjnldsv