user_saml icon indicating copy to clipboard operation
user_saml copied to clipboard

Support reverse proxy the NextCloud way

Open Toilal opened this issue 6 years ago • 4 comments

In some network configurations involving a reverse proxy, the base url generated by the underlying SAML library is not consistent with the way it's generated in NextCloud.

For example, it may generate http:// urls instead of https:// when the SSL Layer is handled by a proxy, even when NextCloud URLGenerator#getAbsoluteURL effectively generates https:// urls.

This change setup SAML library to use the Server Protocol and Server Host as returned by the NextCloud Request object to build SAML urls properly.

Toilal avatar Apr 05 '19 08:04 Toilal

Safari and Firefox both seem to currently display a security warning due to http only URLs in some redirects. It looks like this PR would fix the issue.

hairmare avatar May 16 '19 09:05 hairmare

Right. It makes sense... let me see if I can do a test setup with this.

rullzer avatar May 28 '19 20:05 rullzer

I have rebased on current master. @rullzer Have you made some tests with those changes ?

Toilal avatar Jun 08 '19 22:06 Toilal

I am going through the open PRs and a there is a bunch of dusty ones here :sweat_smile:

Rebased this one. I understand this is still relevant.

blizzz avatar May 02 '25 09:05 blizzz