user_external icon indicating copy to clipboard operation
user_external copied to clipboard

Rewrote "bad" Code to more modern version

Open melvin-suter opened this issue 6 years ago • 2 comments

As discussed in #100 here is the PR with the rewroten if/else statement.

melvin-suter avatar Sep 16 '19 06:09 melvin-suter

thank you very much for your contribution! indeed, your changes make sense however this needs proper testing in different scenarios before merging, but unfortunately I neither have an SMB setup nor enough time to do this at the moment :/

violoncelloCH avatar Oct 05 '19 16:10 violoncelloCH

@ufozone simply "accepting" the PR doesn't really help here, because I don't know what this "accepting" is based on. Instead please test it as much as possible and explain what you tested in detail :)

violoncelloCH avatar Feb 26 '20 18:02 violoncelloCH