unsplash icon indicating copy to clipboard operation
unsplash copied to clipboard

Very bright images make NC icons undiscernable / unusable

Open ndx1905-github opened this issue 3 years ago • 12 comments

use GitHub reactions 👍 to show that you are affected by the same issue. Please don't comment if you have no relevant information to add!

  • [x] This is not a feature request
  • [x] This is not an image-provider request
  • [x] I have searched the issuetracker if the issue is not already reported.

Describe the bug: When a image with very bright light colors is randomly picked up, there is no contrast with NC icons which make it practically unusable (need to reload the page to have more contrast).

To Reproduce: Steps to reproduce the behavior: Refresh page until a very light image is loaded Or.. look at the screenshots provided IMG_2900 IMG_2901

Expected behavior: There should be a shadow or dark line around NC icons. Alternatively, header should be opaque.

Server:

  • Nextcloud version: 24.0
  • Splash-App version: 1.2.5

ndx1905-github avatar May 15 '22 17:05 ndx1905-github

This is not an easy one, and we had issues with contrast in the past. I generally consider this 'working as intended', since we cant check the image before display, to verify it 'looks good'.

However, i have added some featues in the dev-branch that may help. You will eventually be able to apply a tint to each image, which will give you the ability to generally increase contrast with any image that may be loaded

newhinton avatar May 15 '22 18:05 newhinton

Thanks for the quick reply Tint on the whole image is a bit different. Would it be possible to add a tint just behind the header part? Or alternatively make sure the splash image is confined below the header?

ndx1905-github avatar May 15 '22 19:05 ndx1905-github

You can already disable the background image for the header in the settings under theming

newhinton avatar May 15 '22 19:05 newhinton

It's already unticked.

Here is the behavior :

  • if I tick Set random image as header background, then I have the splash background on every page header of every app.
  • if I untick Set random image as header background, then I still have the header backgound on the login page and on the dashboard page. That's where my problem is and the unexpected behavior.

EDIT It's not a problem on the login page (no app icons anyway), but it's a problem on the dashboard page.

ndx1905-github avatar May 15 '22 19:05 ndx1905-github

Okay This made the trick https://github.com/nextcloud/unsplash/issues/92#issuecomment-1097011966

ndx1905-github avatar May 15 '22 20:05 ndx1905-github

I have an idea to fix this permanently

newhinton avatar May 15 '22 20:05 newhinton

Cool !

Just a comment on the css trick from

#header { background: var(--color-primary-element) !important; }

I noticed that in combination with splash :

  • when first loaded, the header is in plain color Capture d’écran 2022-05-15 à 22 38 04

  • if you scroll to the bottom, the header become a gradient of black (maybe because I have a dark mode? no idea). I think that gradient is a very nice feature that I'd like to have as the primary choice instead of plain. Capture d’écran 2022-05-15 à 22 38 19

Just a remark !

ndx1905-github avatar May 15 '22 20:05 ndx1905-github

I have this issues too. I would love the extension to set a consistent semi-transparent header background. I think it would be a nice polish features as opposed to the bight colored bar from the rest of the nextcloud theme.

joewashear007 avatar Jun 03 '22 15:06 joewashear007

grafik

The current dev-branch includes the ability to 'tint' an image. It looks like this, and it always applies the instance-color. This does increase readability, and should be a good way to deal with this issue

grafik

grafik

newhinton avatar Jun 12 '22 09:06 newhinton

It would be great to have this tint functionality only behind the icon line and not for the whole image

ndx1905-github avatar Aug 08 '22 09:08 ndx1905-github

A workaround I'm using, added via the Custom CSS app:

#header > div {
  background: rgba(0, 0, 0, 0.33);
}

This CSS targets the header's inner divs as not to replace the background image, adding a dark overlay below the icons (play with the 0.33 to change opacity).

LaXiS96 avatar Oct 03 '22 19:10 LaXiS96

@LaXiS96 I didn't know about the custom CSS plugin, that's a great workaround!

I tweaked the CSS a little bit, and made the header bar style match up with Nextcloud's dark theme:

body > #header {
  background: rgba(23, 23, 23, 0.8) !important;
  backdrop-filter: blur(25px);
}

.content, #content {
  margin-top: 55px !important;
}

image image

The margin is there so you don't end up with ugly corners like this: image

It would be great to see this built in to the app, or at least an option in the settings. But in the meantime, the Custom CSS app provides a good workaround.

maples3 avatar Aug 27 '23 01:08 maples3