text icon indicating copy to clipboard operation
text copied to clipboard

Fix: initialize undomanager for empty document

Open benjaminfrueh opened this issue 1 month ago • 2 comments

The first paste action in an empty document was not being tracked by the Yjs UndoManager, making it impossible to undo and not tracking it as a change.

This adds initUndoManagerForEmptyDocument() which primes the undo manager by inserting and deleting a space, then clearing the undo stack. This ensures user actions are properly tracked.

benjaminfrueh avatar Nov 19 '25 14:11 benjaminfrueh

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests.

:loudspeaker: Thoughts on this report? Let us know!

codecov[bot] avatar Nov 19 '25 14:11 codecov[bot]

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

github-actions[bot] avatar Dec 04 '25 02:12 github-actions[bot]

After more detailed debugging of the undoManager, I found the root cause and also was able to find a solution. Closing this PR and creating a new one with a fix.

benjaminfrueh avatar Dec 15 '25 09:12 benjaminfrueh

Fixed in https://github.com/nextcloud/text/pull/8063

benjaminfrueh avatar Dec 15 '25 17:12 benjaminfrueh