text icon indicating copy to clipboard operation
text copied to clipboard

fix(SaveService): Don't save if yjs reports pendingStructs

Open mejo- opened this issue 3 months ago • 2 comments

Yjs pendingStructs mean that the local yjs document state is missing a step. So let's not allow to save such an inconstent state to the server.

Screenshot

Disabled save button
disabled_save

🏁 Checklist

  • [x] Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • [x] Sign-off message is added to all commits

mejo- avatar Sep 30 '25 15:09 mejo-

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 59.55%. Comparing base (07cc286) to head (28ee3e7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7704      +/-   ##
==========================================
+ Coverage   59.52%   59.55%   +0.03%     
==========================================
  Files         503      503              
  Lines       39118    39150      +32     
  Branches     1130     1130              
==========================================
+ Hits        23285    23317      +32     
  Misses      15725    15725              
  Partials      108      108              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Sep 30 '25 15:09 codecov[bot]

Waiting for the outcome of our attempts to prevent out of sync state and thus pending structs in the first place.

max-nextcloud avatar Oct 09 '25 09:10 max-nextcloud