text icon indicating copy to clipboard operation
text copied to clipboard

chore(migrate): useEditorMixin to useEditor composable

Open max-nextcloud opened this issue 6 months ago • 1 comments

max-nextcloud avatar Jun 16 '25 12:06 max-nextcloud

Codecov Report

Attention: Patch coverage is 86.07595% with 77 lines in your changes missing coverage. Please review.

Project coverage is 59.66%. Comparing base (1ba51c5) to head (fabc79e). Report is 35 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Suggestion/Mention/suggestions.js 16.66% 20 Missing :warning:
src/extensions/CollaborationCursor.ts 13.33% 13 Missing :warning:
src/composables/useEditorMethods.ts 50.00% 12 Missing :warning:
src/editor.js 0.00% 9 Missing :warning:
src/components/Menu/BaseActionEntry.js 33.33% 8 Missing :warning:
src/components/Menu/ActionInsertLink.vue 14.28% 6 Missing :warning:
src/components/Menu/ActionAttachmentUpload.vue 20.00% 4 Missing :warning:
src/components/Menu/utils.js 42.85% 4 Missing :warning:
src/components/Menu/EmojiPickerAction.vue 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7313      +/-   ##
==========================================
+ Coverage   59.22%   59.66%   +0.44%     
==========================================
  Files         481      486       +5     
  Lines       37149    37285     +136     
  Branches     1048     1097      +49     
==========================================
+ Hits        22000    22245     +245     
+ Misses      15047    14934     -113     
- Partials      102      106       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 16 '25 13:06 codecov[bot]

Current Cypress failures:

Runner 1

~~Assistant spec failure~~

Unrelated.

  • https://github.com/nextcloud/assistant/pull/256 caused it.
  • Fixed it in https://github.com/nextcloud/text/pull/7323.

Menu spec failure

Shows that the word count does not work anymore. I experimented with this some. It seems to already be pretty unreliable in current main branch. Count sometimes does not update when typing new text for example. Debugging showed that the content of the editor inside the CharacterCount component was different from the main content... do we have two editor instances there for some reason?

Runner 5

Share spec failing

When opening a shared file with download disabled the editor should not load. The create request will fail and previously this led to the editor not being loaded at all. Now it's loading as this.editor is already filled in the Editor.vue component. Content is still not showing (as it's not served during create) but it shows the read only toolbar including the show outline button.

We need to decide how we want the editor to behave before the create request / if it fails. I like loading the toolbar before the content - but I'm thinking about the editing toolbar not the read only one.

max-nextcloud avatar Jun 21 '25 06:06 max-nextcloud