text icon indicating copy to clipboard operation
text copied to clipboard

fix: adjust table width for better view

Open AIlkiv opened this issue 8 months ago • 4 comments

📝 Summary

This fix applies only to the view mode

🖼️ Screenshots

🏚️ Before 🏡 After
before_ after_

🚧 TODO

  • [ ] ...

🏁 Checklist

  • [ ] Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • [ ] Sign-off message is added to all commits
  • [ ] Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • [ ] Documentation (README or documentation) has been updated or is not required

AIlkiv avatar May 07 '25 13:05 AIlkiv

@mejo- I agree, but on the other hand, when viewing the page, it looks like an incorrect styles.

Perhaps this layout will be a compromise? demo

AIlkiv avatar May 07 '25 19:05 AIlkiv

What do our designers think? Cc @marcoambrosini

mejo- avatar May 07 '25 19:05 mejo-

I think ideally we want to make the table full width at all times move this "buttons column" outside. Much like the "+" button and link preview button on the left side.

When the screen is smaller and these don't fit, I don't mind the horizontal jump when switching modes. What's more unsettling are vertical jumps. But in this case, either way is fine from my pov.

marcoambrosini avatar May 08 '25 09:05 marcoambrosini

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

github-actions[bot] avatar May 22 '25 03:05 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.58%. Comparing base (e522c75) to head (887d46b). Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7200      +/-   ##
==========================================
+ Coverage   52.67%   59.58%   +6.91%     
==========================================
  Files         487      486       -1     
  Lines       42237    37337    -4900     
  Branches     1098     1097       -1     
==========================================
  Hits        22247    22247              
+ Misses      19883    14984    -4899     
+ Partials      107      106       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jul 02 '25 08:07 codecov[bot]

pushed a small fix to make prettier happy.

max-nextcloud avatar Jul 02 '25 08:07 max-nextcloud