text icon indicating copy to clipboard operation
text copied to clipboard

refactor: cleanup main entry point

Open susnux opened this issue 9 months ago • 4 comments

📝 Summary

  • module chunking is nowadays done automatically so we can simplify the entry point.

🏁 Checklist

  • [ ] Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • [ ] Sign-off message is added to all commits
  • [ ] Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • [ ] Documentation (README or documentation) has been updated or is not required

susnux avatar Apr 04 '25 21:04 susnux

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 59.23%. Comparing base (e9ee278) to head (cb62d30). Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/main.js 0.00% 6 Missing :warning:
src/viewer.js 0.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7074      +/-   ##
==========================================
+ Coverage   58.97%   59.23%   +0.25%     
==========================================
  Files         482      481       -1     
  Lines       37117    37139      +22     
  Branches     1048     1046       -2     
==========================================
+ Hits        21891    21998     +107     
+ Misses      15124    15039      -85     
  Partials      102      102              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Apr 04 '25 21:04 codecov[bot]

@susnux failing cypress test seems related.

mejo- avatar Apr 15 '25 00:04 mejo-

Was missing to call the vue constructur, pushed a fix

juliusknorr avatar Jun 04 '25 06:06 juliusknorr

Failing direct editing test still seems likely to be related.

max-nextcloud avatar Jun 20 '25 13:06 max-nextcloud

Failing direct editing test still seems likely to be related.

rebased, maybe it was just a fluke

susnux avatar Jun 21 '25 13:06 susnux

seems like it, CI is green now

susnux avatar Jun 21 '25 14:06 susnux