text icon indicating copy to clipboard operation
text copied to clipboard

feat(table): add row, column buttons outside of table

Open luka-nextcloud opened this issue 1 year ago • 2 comments

📝 Summary

  • Resolves: #2267

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🚧 TODO

  • [x] check if rows and columns can be added / removed and disable buttons accordingly
  • [x] drop colspan=1, rowspan=1, etc from rendered html - first attempt at this failed

🏁 Checklist

  • [ ] Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • [ ] Sign-off message is added to all commits
  • [ ] Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • [ ] Documentation (README or documentation) has been updated or is not required

luka-nextcloud avatar Oct 17 '24 15:10 luka-nextcloud

Seems like a user interface change so please provide some screenshots ;)

juliusknorr avatar Oct 18 '24 07:10 juliusknorr

Yes, I will. It's not yet ready for review.

luka-nextcloud avatar Oct 18 '24 07:10 luka-nextcloud

Screenshot & video image

demo.webm

luka-nextcloud avatar Oct 22 '24 19:10 luka-nextcloud

@nextcloud/designers Could you please give me your feedback regarding the button? :)

luka-nextcloud avatar Oct 23 '24 12:10 luka-nextcloud

demo.webm

luka-nextcloud avatar Nov 12 '24 12:11 luka-nextcloud