text icon indicating copy to clipboard operation
text copied to clipboard

chore: install @nextcloud/prettier-config, eslint-config-prettier

Open luka-nextcloud opened this issue 1 year ago • 2 comments

📝 Summary

  • Resolves: #6449
  • Install @nextcloud/prettier-config
  • Install eslint-config-prettier
  • Format code with prettier

luka-nextcloud avatar Oct 08 '24 15:10 luka-nextcloud

@max-nextcloud I have checked through prettier config options. The only way to avoid line break is rising the value of printWidth. The current value is 85. I think it will work? BTW, we can use // prettier-ignore to ignore formatting for any code block that we don't want to format.

luka-nextcloud avatar Oct 10 '24 09:10 luka-nextcloud

I like the fact that prettier has so little options. Maybe we can briefly discuss on Monday before moving the code over?

max-nextcloud avatar Oct 11 '24 06:10 max-nextcloud

@luka-nextcloud What are the next steps here? Do we want to continue or close this?

juliusknorr avatar Apr 01 '25 11:04 juliusknorr

@max-nextcloud @juliusknorr I will close this PR and open a new one.

  • Install @nextcloud/prettier-config and eslint-config-prettier
  • Format code with prettier
  • Add flow .github/workflows/lint-prettier.yml
  • Remove flow .github/workflows/lint-stylelint.yml

luka-nextcloud avatar Apr 02 '25 15:04 luka-nextcloud