[stable28] Check link protocol
Backport of #6486
Warning, This backport's changes differ from the original and might be incomplete ⚠️
Todo
- [ ] Review and resolve any conflicts
- [ ] Remove all the empty commits
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.
This backport is more involved as we did not have the link bubble yet in 28.
I think the backport is fine now - I'm still unsure though if this is really the behavior we want. With this change one can only get at the urls from links with extraordinary protocols by editing the link. Clicking the link itself won't open it and right click won't work.
Probably not so bad anyway though as 28 is pretty old and from 29 on we have the link bubble.
Cypress component tests seem to fail fairly reliable.
Maybe they did break with https://github.com/nextcloud/text/pull/6501 ? Before that stable28 seemed fine https://github.com/nextcloud/text/pulls?q=sort%3Aupdated-desc+is%3Apr+is%3Amerged+base%3Astable28
Maybe they did break with #6501 ? Before that stable28 seemed fine https://github.com/nextcloud/text/pulls?q=sort%3Aupdated-desc+is%3Apr+is%3Amerged+base%3Astable28
Good catch. @nextcloud/webpack-vue-config bump also bumped webpack-dev-server.
Okay... so i see several options how to handle this:
- downgrade
@nextcloud/webpack-vue-configsowebpack-dev-servercan be downgraded. - upgrade cypress and skip tests that crash it.
- revert the move of tests from e2e to component tests.
- fix the actual issue with ResizeObserver loop in our code.
They all seem somewhat cumbersome. In addition this issue does not show on current versions as we are using vite there I believe.
I'd go with 1 for the stable branch for now to get this pr in