text icon indicating copy to clipboard operation
text copied to clipboard

[stable28] Check link protocol

Open backportbot[bot] opened this issue 1 year ago • 1 comments

Backport of #6486

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • [ ] Review and resolve any conflicts
  • [ ] Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

backportbot[bot] avatar Oct 02 '24 05:10 backportbot[bot]

This backport is more involved as we did not have the link bubble yet in 28.

max-nextcloud avatar Oct 02 '24 06:10 max-nextcloud

I think the backport is fine now - I'm still unsure though if this is really the behavior we want. With this change one can only get at the urls from links with extraordinary protocols by editing the link. Clicking the link itself won't open it and right click won't work.

Probably not so bad anyway though as 28 is pretty old and from 29 on we have the link bubble.

max-nextcloud avatar Nov 14 '24 14:11 max-nextcloud

Cypress component tests seem to fail fairly reliable.

max-nextcloud avatar Nov 18 '24 14:11 max-nextcloud

Maybe they did break with https://github.com/nextcloud/text/pull/6501 ? Before that stable28 seemed fine https://github.com/nextcloud/text/pulls?q=sort%3Aupdated-desc+is%3Apr+is%3Amerged+base%3Astable28

juliusknorr avatar Nov 18 '24 16:11 juliusknorr

Maybe they did break with #6501 ? Before that stable28 seemed fine https://github.com/nextcloud/text/pulls?q=sort%3Aupdated-desc+is%3Apr+is%3Amerged+base%3Astable28

Good catch. @nextcloud/webpack-vue-config bump also bumped webpack-dev-server.

max-nextcloud avatar Nov 21 '24 09:11 max-nextcloud

Okay... so i see several options how to handle this:

  1. downgrade @nextcloud/webpack-vue-config so webpack-dev-server can be downgraded.
  2. upgrade cypress and skip tests that crash it.
  3. revert the move of tests from e2e to component tests.
  4. fix the actual issue with ResizeObserver loop in our code.

They all seem somewhat cumbersome. In addition this issue does not show on current versions as we are using vite there I believe.

max-nextcloud avatar Nov 21 '24 10:11 max-nextcloud

I'd go with 1 for the stable branch for now to get this pr in

juliusknorr avatar Nov 21 '24 10:11 juliusknorr