text icon indicating copy to clipboard operation
text copied to clipboard

feat: Migrate to files:node:updated

Open luka-nextcloud opened this issue 1 year ago • 4 comments

📝 Summary

  • Resolves: #4054

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🚧 TODO

  • [ ] ...

🏁 Checklist

  • [x] Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • [x] Sign-off message is added to all commits
  • [ ] Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • [x] Documentation (README or documentation) has been updated or is not required

luka-nextcloud avatar Sep 18 '24 17:09 luka-nextcloud

@luka-nextcloud what's the background for this change? Does it fix anything? Is it a technical dept thing?

mejo- avatar Sep 19 '24 14:09 mejo-

@luka-nextcloud what's the background for this change? Does it fix anything? Is it a technical dept thing?

Sorry for not mentioning. This is a technical debt, I've added the issue on the description.

luka-nextcloud avatar Sep 19 '24 14:09 luka-nextcloud

Thanks for the additional context @luka-nextcloud. Do you know what the emitted event is supposed to do? I.e. is there a reproducer of how to test whether this works?

mejo- avatar Sep 23 '24 10:09 mejo-

@mejo- The emitted event is supposed to notify the other apps that a file was updated. Install text app and notes app (with this PR https://github.com/nextcloud/notes/pull/1377) then open notes app to edit a note.

luka-nextcloud avatar Sep 24 '24 16:09 luka-nextcloud

Was just reported as an issue so this likely fixes https://github.com/nextcloud/text/issues/6671

juliusknorr avatar Nov 20 '24 13:11 juliusknorr

  • [x] Double check and test if this resolves https://github.com/nextcloud/text/issues/6671

juliusknorr avatar Nov 20 '24 13:11 juliusknorr

So many cypress failures seem odd, will do another rebase.

juliusknorr avatar Dec 04 '24 07:12 juliusknorr

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 46.88%. Comparing base (18983c9) to head (3da9c10). Report is 95 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Editor.vue 0.00% 18 Missing :warning:
src/services/WebdavClient.ts 0.00% 9 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6427      +/-   ##
==========================================
- Coverage   46.90%   46.88%   -0.03%     
==========================================
  Files         746      739       -7     
  Lines       33984    33999      +15     
  Branches     1239     1232       -7     
==========================================
  Hits        15940    15940              
- Misses      17424    17446      +22     
+ Partials      620      613       -7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 13 '24 08:12 codecov[bot]

[x] Double check and test if this resolves

Can we backport to 30 and 29?

susnux avatar Jan 13 '25 07:01 susnux

/backport to stable30

juliusknorr avatar Jan 13 '25 08:01 juliusknorr

/backport to stable29

juliusknorr avatar Jan 13 '25 08:01 juliusknorr