feat: Migrate to files:node:updated
📝 Summary
- Resolves: #4054
🖼️ Screenshots
| 🏚️ Before | 🏡 After |
|---|---|
| B | A |
🚧 TODO
- [ ] ...
🏁 Checklist
- [x] Code is properly formatted (
npm run lint/npm run stylelint/composer run cs:check) - [x] Sign-off message is added to all commits
- [ ] Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
- [x] Documentation (README or documentation) has been updated or is not required
@luka-nextcloud what's the background for this change? Does it fix anything? Is it a technical dept thing?
@luka-nextcloud what's the background for this change? Does it fix anything? Is it a technical dept thing?
Sorry for not mentioning. This is a technical debt, I've added the issue on the description.
Thanks for the additional context @luka-nextcloud. Do you know what the emitted event is supposed to do? I.e. is there a reproducer of how to test whether this works?
@mejo- The emitted event is supposed to notify the other apps that a file was updated. Install text app and notes app (with this PR https://github.com/nextcloud/notes/pull/1377) then open notes app to edit a note.
Was just reported as an issue so this likely fixes https://github.com/nextcloud/text/issues/6671
- [x] Double check and test if this resolves https://github.com/nextcloud/text/issues/6671
So many cypress failures seem odd, will do another rebase.
Codecov Report
Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.
Project coverage is 46.88%. Comparing base (
18983c9) to head (3da9c10). Report is 95 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/components/Editor.vue | 0.00% | 18 Missing :warning: |
| src/services/WebdavClient.ts | 0.00% | 9 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #6427 +/- ##
==========================================
- Coverage 46.90% 46.88% -0.03%
==========================================
Files 746 739 -7
Lines 33984 33999 +15
Branches 1239 1232 -7
==========================================
Hits 15940 15940
- Misses 17424 17446 +22
+ Partials 620 613 -7
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
[x] Double check and test if this resolves
Can we backport to 30 and 29?
/backport to stable30
/backport to stable29