fix: ctrl+backspace in list item on firefox
📝 Summary
- Resolves: #5839
The issue came from old version of package prosemirror-view. It triggered "Enter" key from wrong detection logic. This issue was fixed on new prosemirror-view release.
🖼️ Screenshots
| 🏚️ Before | 🏡 After |
|---|---|
| B | A |
🚧 TODO
- [ ] ...
🏁 Checklist
- [ ] Code is properly formatted (
npm run lint/npm run stylelint/composer run cs:check) - [ ] Sign-off message is added to all commits
- [ ] Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
- [ ] Documentation (README or documentation) has been updated or is not required
Thanks for checking that.
Let me put some references here as well: https://github.com/ProseMirror/prosemirror-view/blob/master/CHANGELOG.md#1337-2024-05-31 https://github.com/ProseMirror/prosemirror-view/commit/8c9a7d25021ce8e99d03a63c7fb7033a524fd4db
Was bumped in tiptap upstream for the upcoming 2.5.0 release with https://github.com/ueberdosis/tiptap/commit/747985b3a7617e35702a6dab4ecc87c76610204b
@luka-nextcloud @max-nextcloud Any oppinion on having direct prosemirror dependencies again in our package.json? I feel this could cause issues in the future if tiptap ships another version. Shall we just wait for the upstream update? Or merge and revert fixed in upstream?
I think if this issue is not urgent, we'd better wait for the new tiptap release.
Left a comment about this in the issue