text icon indicating copy to clipboard operation
text copied to clipboard

[draft] [stable28] perf(rich_workspace): only add property for parent

Open ShGKme opened this issue 1 year ago • 0 comments

Draft on 28, just because I was investigating on 28. I'll recreate on main soon

📝 Summary

Steps to reproduce

  1. Add 300-500 s3 external storages and mount to root subfolder
  2. Enable text
  3. See 10-15s loading time on /apps/files/files for PROPFIND request. On real instance it could be up to 90 seconds for 300 storages
s3 28 27
0 0.1s 0.1s
100 3s 0.2s
200 6s 0.5s
300 9s 0.9s
400 12s 1-2s
500 15s 1.1-2.4s

A problem

There is a new <nc:rich_workspace> property for each Node in the response.

After disabling Text or disabling rich_workspace the problem disappears.

🚧 TODO

  • [x] only add property for parent ignoring deep nodes as it was in past

🏁 Checklist

  • [x] Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • [x] Sign-off message is added to all commits
  • [ ] Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • [x] Documentation (README or documentation) has been updated or is not required

ShGKme avatar Jun 27 '24 14:06 ShGKme