text icon indicating copy to clipboard operation
text copied to clipboard

Link preview follow up

Open juliusknorr opened this issue 1 year ago • 2 comments

Follow up from https://github.com/nextcloud/text/pull/5399

  • [x] Do not render interactive widgets in link bubble (set interactive prop to false on the NcReferenceList component)
  • [x] #5443
  • [x] #5444
  • [x] #5445
  • [x] #5518
  • [x] #5522
  • [x] #5524
  • [x] #5539
  • [x] #5723
  • [x] test for backspace (follow up on #5444)
  • [ ] edit link target from menu

juliusknorr avatar Mar 07 '24 07:03 juliusknorr

image

^ I've noticed that when the link preview fails with the github integration there is no way to click your way to the link. You have to use the Copy link to clipboard action and open a new tab yourself.

I can file a separate issue if this isn't the right place to post this.

ChristophWurst avatar Apr 05 '24 08:04 ChristophWurst

Yes, a separate ticket would be nice. Might actually be good to file it with the integration_github app as within text we do not have control over what the widget is doing.

juliusknorr avatar Apr 05 '24 13:04 juliusknorr

@max-nextcloud Editing the link target from the modal might be tricky as the mark might span multiple nodes or also overlap with other marks. I'd say something we should split in a separate ticket as it might be larger work.

juliusknorr avatar May 03 '24 08:05 juliusknorr

Postponing the editing of link targets until the next iteration on links.

max-nextcloud avatar May 08 '24 07:05 max-nextcloud