text icon indicating copy to clipboard operation
text copied to clipboard
verified publisher icon nextcloud

Enh/preview links

Open max-nextcloud opened this issue 1 year ago • 1 comments

📝 Summary

  • Resolves: #5270

🖼️ Screenshots (wip)

Bildschirmaufzeichnung vom 20.02.2024, 12:23:34.webm

🚧 TODO

  • [ ] allow turning the preview back into a link
  • [ ] close bubble when opening menu
  • [ ] squash commits in meaningful way.
  • [ ] close menu when opening bubble
  • [ ] edit link target from menu

🏁 Checklist

  • [ ] Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • [ ] Sign-off message is added to all commits
  • [ ] Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • [ ] Documentation (README or documentation) has been updated or is not required

max-nextcloud avatar Feb 20 '24 17:02 max-nextcloud

Had a first quick code read and looks very reasonable from the implementation approach 💪 - will check in further detail once you request review

juliusknorr avatar Feb 20 '24 20:02 juliusknorr

Pushed a small fix for eslint

juliusknorr avatar Mar 07 '24 06:03 juliusknorr

Filed follow ups as https://github.com/nextcloud/text/issues/5442

juliusknorr avatar Mar 07 '24 07:03 juliusknorr