text icon indicating copy to clipboard operation
text copied to clipboard
verified publisher icon nextcloud

Bring back test failing due to server issue

Open max-nextcloud opened this issue 2 years ago • 1 comments

This reverts commit 77d77561fc835335a72b6fecc6d5f53d895ca8e1.

Merge once

  • https://github.com/nextcloud/server/issues/42306 is fixed.

🏁 Checklist

  • [x] Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • [x] Sign-off message is added to all commits
  • bringing back a test case that was skipped - no new tests or docs needed.

max-nextcloud avatar Dec 18 '23 10:12 max-nextcloud

/backport to stable28

juliusknorr avatar Dec 18 '23 16:12 juliusknorr

@mejo- Are you sure this one is fixed? Upstream issue is still open but it looks like the test was flaky because files could not be deleted during preview generation.

Here's the actual fix for the tests in groupfolders: https://github.com/nextcloud/groupfolders/pull/2806/files#diff-916f4714b496997bded1e151f955f0ac5f76f562ad64c465e58b1c4f01589841R124-R130

max-nextcloud avatar Mar 16 '24 20:03 max-nextcloud

@max-nextcloud to be honest I just rebased and saw that the tests passed. So I merged it. And I didn't see the test in question failing on main branch since then.

mejo- avatar Mar 17 '24 18:03 mejo-

And I didn't see the test in question failing on main branch since then.

Cool. As long as it stays green we're good then i guess. Otherwise we know where to look. I'll close the issue in server.

max-nextcloud avatar Mar 19 '24 06:03 max-nextcloud