text icon indicating copy to clipboard operation
text copied to clipboard

Document status notice with connection issues is not sticky

Open mejo- opened this issue 2 years ago • 2 comments

Describe the bug The document status notice that displays connection issues is not sticky anymore.

See https://github.com/nextcloud/text/pull/4474#issuecomment-1630971483 for a screenshot.

To Reproduce Steps to reproduce the behavior:

  1. Open a Text document with content long enough to scroll.
  2. Open network tab of browser developer tools, block network.
  3. Type something, see the notice about connection issues pop up.
  4. See that the notice is not sticky.

mejo- avatar Jul 11 '23 15:07 mejo-

Recording from #5100

Peek 2023-12-07 12-43

juliusknorr avatar Jan 17 '24 14:01 juliusknorr

Once at it one could also address https://github.com/nextcloud/text/issues/4905

A possible fix needs careful testing of different ways that the text editor is embedded in scroll containers:

  • Single file opened in the viewer as a logged in user
  • Open a file on a public share link of that file
  • Open a file on a publich share link of a folder
    • Make sure to test this with Talk enabled and disabled as talk registers a sidebar on the public share pages
  • Collectives regular page and share links
  • Notes

juliusknorr avatar Jan 25 '24 12:01 juliusknorr

Already fixed at https://github.com/nextcloud/text/commit/59e6bf53ff1f7891169617df1ba7cd22abf1e59a

enjeck avatar Mar 22 '24 14:03 enjeck