text icon indicating copy to clipboard operation
text copied to clipboard

Table of contents: add button to close outline from itself

Open mejo- opened this issue 3 years ago • 5 comments

Describe the bug The table of contents can only be opened and closed by navigating to the headings submenu in the menubar. While this is fine for opening the outline, it feels quite cumbersome for closing it. We should add a button to the outline view to close it from itself.

mejo- avatar Sep 12 '22 13:09 mejo-

@vinicius73

mejo- avatar Sep 12 '22 13:09 mejo-

Sorry, I only tested the outline on Collectives and there the heading and close button were hidden by the menubar. I fixed this now by adding the following in Collectives:

[data-text-el='editor-container'] .editor--outline {
	z-index: 10021;
}

mejo- avatar Sep 13 '22 08:09 mejo-

Well, the better solution would be to remove top: 104px from https://github.com/nextcloud/text/blob/9a45c935dd4451a83c8cc0b9f6a6575262ad7c54/src/components/Editor/EditorOutline.vue#L66. What was the reason that you added it @vinicius73?

mejo- avatar Sep 13 '22 08:09 mejo-

I'm working in this approach.

https://user-images.githubusercontent.com/1561347/190250989-696a4ea5-d932-48c2-8c51-13076a383667.mp4

vinicius73 avatar Sep 14 '22 20:09 vinicius73

Well, the better solution would be to remove top: 104px from

https://github.com/nextcloud/text/blob/9a45c935dd4451a83c8cc0b9f6a6575262ad7c54/src/components/Editor/EditorOutline.vue#L66

. What was the reason that you added it @vinicius73?

I've removed it 😉

vinicius73 avatar Sep 14 '22 20:09 vinicius73