nextcloud
Replace MenuBubble with a menu bar entry for links
- Resolves: #2162, and resolves #2392, and resolves #1528 (adds the missing functionality to remove link marks)
- Supersedes #2519
- Target version: master
Summary
This replaces the popover MenuBubble used for inserting links with a menu entry in the menu bar. This also allows to add links also to directories, previously only files were allowed as link targets.
Added cypress tests as well. Testing inserting links to files, to directories, and also inserting links while nothing is selected to test if the correct file name is used.
Some the menu order is slightly changed to prevent the link menu to get hidden, like for the callouts
Actions must not get hidden in the submenu (nesting does not work for the menu).
Another feature introduced with this change is the ability to insert links to files and automatically use the filename as the link text.
Thanks a lot for working on this @susnux! I'm much in favor of moving the link tools into the menu bar. But I'd say let's get #2611 merged first and then look at this one :relaxed:
Thanks a lot for working on this @susnux! I'm much in favor of moving the link tools into the menu bar. But I'd say let's get #2611 merged first and then look at this one relaxed
Thank you, no problem :) I just would like to see this in one of the next releases as the menu bubble is quite annoying (I always have to scroll up for the bubble to be show even if I insert links at the bottom -.- )
@susnux thanks a lot! Would you mind adding a few screenshots to make it easier for our design team to review?
Would you mind adding a few screenshots to make it easier for our design team to review?
No problem!
Menu entry
Link submenu
Enter an URL
Editing an existing link
Thank you for the screenshots! Some feedback:
Thank you for your feedback! Fixed the first points, I will have a look at the last one soon.
ActionButton and ActionInput have different min-width. Fixed this by setting the min-width of button to the input.
The updated anchor link cypress test fails though. Could you take a look @susnux? Afterwards good to go from my side :+1:
The updated anchor link cypress test fails though. Could you take a look @susnux? Afterwards good to go from my side +1
Should be fixed now, works locally waiting for CI to succeed :)
For some reason, the node build + porcelain check CI job always reports a diff 🙁 Will have to look into it next week.
Not sure if this can be backported to NC25, but would it be acceptable to backport at least the "link to folders" part?
Usually we don't backport features to stable releases except if there's a strong reason to do so.