text icon indicating copy to clipboard operation
text copied to clipboard

Require optional CI checks to succeed

Open max-nextcloud opened this issue 2 years ago • 1 comments

Github can only require CI checks to always succeed. If they do not run because a path filter is in effect the merge will be blocked.

https://github.com/dorny/paths-filter#conditional-execution could enable conditionally running actions and still require them.

max-nextcloud avatar May 06 '22 15:05 max-nextcloud

For reference: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/troubleshooting-required-status-checks

vinicius73 avatar May 06 '22 21:05 vinicius73

Started playing with this in https://github.com/nextcloud/richdocuments/pull/2518 one thing we might need is another job at the end that builds a summary and still passes if jobs are skipped.

juliusknorr avatar Oct 17 '22 18:10 juliusknorr

Given that we still have flaky Cypress tests from time to time, I'm not sure whether we want to make them mandatory in the first place :thinking:

mejo- avatar Nov 01 '22 11:11 mejo-