text icon indicating copy to clipboard operation
text copied to clipboard
verified publisher icon nextcloud

Table tweaks

Open max-nextcloud opened this issue 3 years ago • 3 comments

Some of these were originally posted by @juliushaertl in https://github.com/nextcloud/text/pull/2235#issuecomment-1077682558 and by @max-nextcloud in https://github.com/nextcloud/text/issues/2235#issuecomment-1075993639

In order of priority:

  • [x] make text after a table start below - not next to it on the right #2289
  • [x] hide table editing buttons in read only editor #2289
  • [ ] check if rows and columns can be added / removed and disable buttons accordingly
  • [x] ~~refactor test layout, put all tables fixtures in one folder~~
  • [ ] accessibility for adding columns and rows (currently tab moves past the buttons in the cells)
  • [ ] drop colspan=1, rowspan=1, etc from rendered html - first attempt at this failed.
  • [x] #3304 (allow left, right and center align of columns)
  • [ ] https://github.com/nextcloud/text/issues/2266

max-nextcloud avatar Mar 31 '22 06:03 max-nextcloud

@max-nextcloud

refactor test layout, put all tables fixtures in one folder

I don't really understand this point. Currently, the table fixtures is only one file cypress/fixtures/Table.md. Do you mean to split this file into many smaller files and put them into a folder?

drop colspan=1, rowspan=1, etc from rendered html - first attempt at this failed.

I don't really understand this point. Image

luka-nextcloud avatar Oct 10 '24 16:10 luka-nextcloud

I don't really understand this point. Currently, the table fixtures is only one file cypress/fixtures/Table.md. Do you mean to split this file into many smaller files and put them into a folder?

I don't remember either. I think i was referring to the fixtures in src/tests/fixtures/tables - maybe to combine them with the ones in the cypress fixture, or to change the folder structure. Now there are two subfolders for two different scenarios - which makes sense from my point of view. So I crossed out this point and checked it off.

max-nextcloud avatar Oct 14 '24 09:10 max-nextcloud

I don't really understand this point.

https://github.com/nextcloud/text/blob/6453780dffd25630c2ccec6c123ca137875769a3/src/tests/fixtures/tables/handbook/handbook.out.html#L6 has the output of tiptap.getHTML() from an editor with tables from the old handbook source.

It has colspan="1" and rowspan="1" all over the place - even though that's not needed - as it's the default.

Funny though - when looking at a table in the browser there are no colspan and rowspan properties - maybe this is just on copy and paste.

max-nextcloud avatar Oct 14 '24 09:10 max-nextcloud