text icon indicating copy to clipboard operation
text copied to clipboard

sync causes conflict even if no edits have occurred

Open brainchild0 opened this issue 5 years ago • 4 comments

If a file is open in the editor, but has not been changed, and if an updated version is pushed from a client through file synchronization, then the editor reports a conflict, instead of simply loading the new version pushed from the client.

Worse, the same behavior occurs even when the editor is active in viewing mode, as for a read-only public share.

The following steps will reproduce the issue:

  1. Create a file in a synchronized folder. Be sure that the desktop client is running and that synchronization is enabled.
  2. Open the file in the editor. Make no changes.
  3. Open the file in an editor running locally on the client system. Make changes and save. Allow the file to synchronize with the server.
  4. Return to the editor in the browser.

Then the editor in the browser should simply refresh the content from the local changes.

Presently, the editor reports a conflict, and asks the user to choose between the two versions to resolve the conflict. (In viewing mode, the editor simply continues to display the outdated version.)


Text app version: 3.1.0 Operating system: Linux Web server: Apache Database: MariaDB PHP version: 7.3.24 Nextcloud version: 20.0.2

brainchild0 avatar Nov 29 '20 13:11 brainchild0

I can confirm this, happens here as well.

arnowelzel avatar Dec 03 '20 22:12 arnowelzel

Thanks for your bug report. Please fill out the issue template to provide some more information about your setup and possible errors in the logfiles.

juliusknorr avatar Dec 07 '20 07:12 juliusknorr

This might be caused by #593.

claell avatar Mar 13 '21 11:03 claell

Is there any update on this?

This issue makes it pretty much impossible to use Text's view feature to share documents with other people if they're being edited locally. I'd love to use the Text preview view to share some of my notes with other people, but because I edit them on my computer rather than on Nextcloud, I keep having to go there to resolve conflicts, even though I never actually edit the file in Text.

Ellpeck avatar Sep 10 '22 13:09 Ellpeck

If I am understanding the issue correctly this sounds like a feature request for syncing text sessions with external changes.

This might be possible when opening files read-only. If a conflict occurs we can reload the document from server as the read-only session is not making changes anyway.

Raudius avatar Nov 16 '22 13:11 Raudius

Agreed, this is kind of what https://github.com/nextcloud/text/issues/233 describes so I'd close this one as a duplicate.

juliusknorr avatar Nov 16 '22 14:11 juliusknorr

If I am understanding the issue correctly this sounds like a feature request for syncing text sessions with external changes.

There are different assumptions. To my mind, a session opens when the user commits new content, not when the content is viewed. Discovering a conflict as though content were separately modified, when only one source of modification has occurred, is a bug.

brainchild0 avatar Nov 16 '22 15:11 brainchild0