terms_of_service icon indicating copy to clipboard operation
terms_of_service copied to clipboard

TOS breaks PicoCMS

Open codejp3 opened this issue 6 years ago • 7 comments

"Call to undefined method ParsedownExtra::textElements()" in PicoCMS with TOS enabled.

Please reference the thread on PicoCMS about this issue.

https://github.com/nextcloud/cms_pico/issues/97

codejp3 avatar Dec 11 '19 06:12 codejp3

@nickvergessen @PhrozenByte I will lift this issue as important to solve. I want both social login and PicoCMS Is Parsedown necessary for TOS?

rollanders avatar Jan 31 '20 07:01 rollanders

Is Parsedown necessary for TOS?

We use it to be able to use markdown in your terms of service, so yes kind of.

nickvergessen avatar Jan 31 '20 08:01 nickvergessen

Ref https://github.com/ChristophWurst/nextcloud_sentry/pull/172

ChristophWurst avatar Jan 31 '20 14:01 ChristophWurst

@ChristophWurst Subscribed to your issue for updates. Since it's an ecosystem issue, are we going to see this being officially supported by Nextcloud? IMO it would be a good thing to give @coenjacobs some support (and some visibility) by Nextcloud, as it looks like he's doing this on his own... It's neither just Guzzle nor Parsedown, it's kind of a miracle that these kind of conflicts don't happen more often...

PhrozenByte avatar Jan 31 '20 16:01 PhrozenByte

Well every app can/should do this when it has such problems. It's nothing Nextcloud can fix for all app maintainers

nickvergessen avatar Jan 31 '20 19:01 nickvergessen

@nickvergessen It's all about recommendations and documentation :wink:

PhrozenByte avatar Jan 31 '20 20:01 PhrozenByte

I want to explore these tools a bit more. If they can be used reliably, we can add them to our docs.

While it currently doesn't help with Guzzle conflicts, it could work with parsedown. You may look at my PR and just try to apply it here. Then check if the app still works :)

ChristophWurst avatar Feb 03 '20 08:02 ChristophWurst