tasks icon indicating copy to clipboard operation
tasks copied to clipboard

fix: don't close sidebar when clicking outside

Open jaylinski opened this issue 11 months ago • 1 comments

Fixes #2510

This logic (closing sidebar when clicking outside) was introduced in #194. I don't know if this was done deliberately or by accident, but I agree with #2510: the app-sidebar should stay open when clicking outside (like it is done in other apps). With this change, the app-sidebar will only change if the a different route is pushed.

Since this change is similar to nextcloud-libraries/nextcloud-vue/issues/1070, I also changed how the app-navigation on mobile behaves. As far as I understand (and how I as a user feel), the app-navigation should close when clicking in the content-area (if on a mobile device).

jaylinski avatar Feb 02 '25 21:02 jaylinski

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

github-actions[bot] avatar Feb 17 '25 02:02 github-actions[bot]

@jaylinski @raimund-schluessler

Thanks for much for fixing this one! It's been a big annoyance for me.

RayBB avatar Sep 11 '25 20:09 RayBB