talk-ios icon indicating copy to clipboard operation
talk-ios copied to clipboard
verified publisher icon nextcloud

Fixed the UI not updating when the room is Locked/Unlocked

Open rapterjet2004 opened this issue 4 months ago • 3 comments

  • fixes #2082

Updated the room upon receiving a processRoomListEvent in the NCExternalSignalingController.

Is this the right way to implement this? Not sure if updating is a heavy operation or not. On Android we have the room state updated upon receiving a new capability from the server, which is then reflected in the UI.

https://github.com/user-attachments/assets/a6f4cf8b-38e5-4364-9d7a-c2a0bf317b41

rapterjet2004 avatar Sep 02 '25 17:09 rapterjet2004

Cool stuff, thanks! Need to take a closer look of that is the best way to solve, out of my head I am not totally sure.

SystemKeeper avatar Sep 08 '25 19:09 SystemKeeper

Do you also re-fetch the room from the server whenever you receive an update message from the external signaling on Android? Even though that solution works, I think the best and most performant solution would be to check the updated attributes included in the update message and update the room locally, without making an additional request to the server.

Ivansss avatar Sep 10 '25 16:09 Ivansss

The recently merged pinning PR is doing something similar to directly act on the system message:

https://github.com/nextcloud/talk-ios/blob/ee12fd34c24b95dd67b867606a69e7ede05cf855/NextcloudTalk/Chat/ChatViewController.swift#L1785-L1792

I think we can adopt this for this here as well?

SystemKeeper avatar Dec 16 '25 21:12 SystemKeeper