talk-ios
talk-ios copied to clipboard
Clearer Mark as Read/Unread icons
See #2088. Opening a new pull request as I cannot reopen the previous one because master has been renamed to main.
@nimishavijay agreed that this is nonetheless an improvement and there isn't a better icon in SF Symbols.
Opening a new pull request as I cannot reopen the previous one because master has been renamed to main.
Oops, sorry for that :)
@nimishavijay agreed that this is nonetheless an improvement and there isn't a better icon in SF Symbols.
Sorry to say, but I still don't see any improvement here. (But I can also see, that an eye might also not be the best choice...)
I am wondering... Since SF icons can be customized, wouldn't something like this work better?
Oh if possible, totally. How can they be customized :o
I do have to say, only if we can place the badge on the top, as it looks quite awkward on the bottom
possible :-)
You can do that in the SF Symbols app, create a custom one with a right click and then (also via context menu) add badges
But to be honest, I discovered that option about an hour ago 🙈
Wow! cool stuff! SF Symbols is so much more advanced than the competition :)
Let me add it to the PR
Alright, I updated it with the custom icon.
I suppose my strategy of “I don’t want to download the iOS SDK again, I’m sure it’ll just work” didn’t :D
Haha, shall I take over?
Haha, shall I take over?
You know, after a failed git rebase on my part? Sure, thanks 🫠
Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.
We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.
Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6
Thank you for contributing to Nextcloud and we hope to hear from you soon!
(If you believe you should not receive this message, you can add yourself to the blocklist.)
Ok, I downloaded the SDK anyway to test it and applied your patch now. It's ready to go. Sorry for the trouble.