talk-ios icon indicating copy to clipboard operation
talk-ios copied to clipboard

New messages are shown with a UI "hiccup" instead of a scroll down animation

Open e-caste opened this issue 2 years ago • 5 comments

Steps to reproduce

  1. Receive a message
  2. Open the corresponding chat
  3. The chat jumps down to show the latest message(s)

Expected behaviour

The new messages should be shown with an animation, possibly scrolling down, or simply already be there when the chat is opened.

Actual behaviour

The chat "jumps" down instantly, which is unpleasant to look at and very frequent. The same issue for messages under the "New messages" label has been solved https://github.com/nextcloud/talk-ios/issues/992

Device information

Device: iPhone X

iOS version: 16.4.1

Talk version: 16.0.2

Server information

Nextcloud version: (see admin overview page: /index.php/settings/admin/overview) 26.0.2

Talk version: (see apps admin page: /index.php/settings/apps) 16.0.3

Custom Signaling server configured: yes/no and version (see talk admin settings: /index.php/settings/admin/talk#signaling_server) no

Custom TURN server configured: yes/no (see talk admin settings: /index.php/settings/admin/talk#turn_server) yes

Custom STUN server configured: yes/no (see talk admin settings: /index.php/settings/admin/talk#stun_server) yes

Server log (data/nextcloud.log)

Insert your server log here

e-caste avatar May 03 '23 20:05 e-caste

Hey @e-caste, thanks for the report. Sorry to be the one again to say something like "I can't reproduce it' :-(. Is it possible to get a recording of what you're seeing? I have not seen a animation issue with receiving new messages in my day-to-day use.

SystemKeeper avatar May 04 '23 08:05 SystemKeeper

@SystemKeeper hi, I have tried to reproduce this in a newly created test conversation but I can confirm it doesn't show. Instead, in an extremely long conversation I have (but it's private so I can't really record it) the effect is the following:

  1. I get a new message (which I see from a notification and in the chat list in the Talk app)
  2. when I open the chat: if there is the unread messages marker, then now (after the latest update) it scrolls down -- otherwise (new message but no unread messages marker), instead of being animated, the message just pops up into existence without animation.

So if the chat was:

  • hi
  • how are you?

and they reply with "fine", the chat immediately changes without any animation from the above to:

  • hi
  • how are you?
  • fine

e-caste avatar May 04 '23 10:05 e-caste

So this does only happen when you enter a chat or also when you are already in a chat and receive a new message? Is it always the case that when you enter a chat (and this happens) no unread marker is visible?

SystemKeeper avatar May 04 '23 20:05 SystemKeeper

Only when I enter a chat and before the update it also happened with the unread marker, now it looks like you've added the animation for that. Unfortunately it's not clear to me when the unread marker is or is not displayed, so I can't reproduce it at will

e-caste avatar May 04 '23 21:05 e-caste

Unfortunately it's not clear to me when the unread marker is or is not displayed, so I can't reproduce it at will

So in general the unread marker is shown when you enter a room and the last read message is not the latest one. But you need to differentiate two more things

  • Messages loading from the server after entering a conversation (so they were not stored on the device before)
  • Messages already stored at the device, so they are loaded instantly when entering a conversation (but still (should) show the unread marker)

So for the first one, you could

  • Leave the app at the room list
  • Send a message to the device
  • Enter the conversation before it shows a new unread message (and don't pull down to reload)

For the second you could:

  • Leave the app at the room list
  • Send a message to the device
  • Pull down the room list to reload and wait a few seconds (this will also load the unread messages already and store them)
  • Enter the conversation

SystemKeeper avatar May 04 '23 21:05 SystemKeeper