talk-desktop icon indicating copy to clipboard operation
talk-desktop copied to clipboard

Add Publish to Windows Package Manager (`winget`) to CI jobs

Open ShGKme opened this issue 1 year ago • 6 comments

Making it manually with wingetcreate is straightforward. But it should be automated.

ShGKme avatar Nov 25 '24 10:11 ShGKme

I guess it's normal as it's not automated yet, but winget is still on 1.0.0-rc2 where it should be v1.0.0

Thanks :)

Refhi avatar Dec 09 '24 14:12 Refhi

I guess it's normal as it's not automated yet, but winget is still on 1.0.0-rc2 where it should be v1.0.0

Hmm... The PR has been merged on the release date. But winget still shows the old version...

https://github.com/microsoft/winget-pkgs/pull/195980

ShGKme avatar Dec 16 '24 19:12 ShGKme

Hmm x2, 1.0.0 has actually been successfully published.

Image

According to the docs, 1.0.0 should be bigger than 1.0.0-rc2, but it is not. It seems that part 0 is not bigger than 0-rc2...

ShGKme avatar Dec 16 '24 20:12 ShGKme

See comparisons Table The -rc causes Version B to have a string in the second Part where Version A does not https://github.com/microsoft/winget-pkgs/blob/master/doc/Authoring.md#examples-of-version-comparisons

ETSPMeder avatar Dec 17 '24 11:12 ETSPMeder

See comparisons Table The -rc causes Version B to have a string in the second Part where Version A does not

See "Comparison Result" in the table. It says Version A which means 1.2 > 1.2-rc

Version A Version B Comparison Result Explanation
1.2 1.2-rc Version A TheĀ -rcĀ causesĀ Version BĀ to have aĀ stringĀ in the secondĀ PartĀ whereĀ Version

ShGKme avatar Dec 17 '24 15:12 ShGKme

Could try with a dot (after the word rc) next time. I remember a similar thing from the past i think version compare in php does it similarly, this is why we use v20.1.0-rc.3 and so on in talk. Otherwise we just never publish rcs there again

nickvergessen avatar Dec 17 '24 16:12 nickvergessen