talk-desktop icon indicating copy to clipboard operation
talk-desktop copied to clipboard

Clicking on notifications does not work in Windows Squirrel build

Open p-try opened this issue 9 months ago • 1 comments

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Steps to reproduce

  1. Install the Windows Squirrel build (1.1.5, latest main, or from winget) on Windows 11 24H2 or 23H2.
  2. Click on an incoming chat notification.

Expected behaviour

App window is supposed to be shown.

Actual behaviour

Nothing happens

Diagnosis and logs

In the Wix (MSI) build, this issue does not appear. Clicking on notifications works as expected.

Up to this, this sounds like the classic setAppUserModelId thing. But this is accounted for in the code, and I can see no issue with it: https://github.com/nextcloud/talk-desktop/blob/7b6f252c79eef79151d25a7060a6ebd75689d5b4/src/main.js#L50

Now here comes the weird stuff: As soon as I change this id to anything (really anything) else, it starts working. The notifications don't show an icon anymore, and title is wrong, but clicking works and the app window opens. Example:

if (isSquirrel) {
	// Squirrel.Windows sets the AppUserModelId in the following way
	app.setAppUserModelId('com.squirrel.NextcloudTalkXYZ.NextcloudTalkXYZ')
} else {

Is anybody able to shed some light on this?

p-try avatar Mar 18 '25 10:03 p-try

This is a known issue, I have a draft with the fix. Checking that uninstalling is covered.

As soon as I change this id to anything (really anything) else, it starts working. The notifications don't show an icon anymore, and title is wrong, but clicking works and the app window opens. Example:

Squirrel sets the appId specifically to com.squirrel.NextcloudTalk.NextcloudTalk. Setting appId from Electron to a different value is not a solution - it will break many things having incorrect appId.

The problem is with the shortcut Squirrel generates on install. Generating/removing it manually solves the problem.

ShGKme avatar Mar 18 '25 15:03 ShGKme