Swipe Down support on Media files
- fixes #5609
🏁 Checklist
- [ ] ⛑️ Tests (unit and/or integration) are included or not needed
- [ ] 🔖 Capability is checked or not needed
- [ ] 🔙 Backport requests are created or not needed:
/backport to stable-xx.x - [ ] 📅 Milestone is set
- [ ] 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)
Codacy
Lint
| Type | master | PR |
| Warnings | 99 | 99 |
| Errors | 0 | 0 |
SpotBugs
| Category | Base | New |
|---|---|---|
| Bad practice | 6 | 6 |
| Correctness | 10 | 10 |
| Dodgy code | 54 | 54 |
| Internationalization | 3 | 3 |
| Malicious code vulnerability | 3 | 3 |
| Performance | 4 | 4 |
| Security | 1 | 1 |
| Total | 81 | 81 |
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5622.apk
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
After thinking about it, I think it might be better to refactor these full screen viewers to use fragments instead in a follow up PR. That way they can just use a Bottom Sheet, which IMO has a better UX. @AndyScherzinger thoughts?
Sounds good to me for a follow up but don't think that would be a priority right now. For example getting the sdk bumped to 36 to unblock library updated from being merged would be more important.
I am also fine with the current state since it is already an improvement but leave the review to @mahibi