talk-android icon indicating copy to clipboard operation
talk-android copied to clipboard

Swipe Down support on Media files

Open rapterjet2004 opened this issue 4 weeks ago • 4 comments

  • fixes #5609

🏁 Checklist

  • [ ] ⛑️ Tests (unit and/or integration) are included or not needed
  • [ ] 🔖 Capability is checked or not needed
  • [ ] 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • [ ] 📅 Milestone is set
  • [ ] 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

rapterjet2004 avatar Dec 05 '25 16:12 rapterjet2004

Codacy

Lint

TypemasterPR
Warnings9999
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

github-actions[bot] avatar Dec 05 '25 17:12 github-actions[bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5622.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

github-actions[bot] avatar Dec 05 '25 17:12 github-actions[bot]

After thinking about it, I think it might be better to refactor these full screen viewers to use fragments instead in a follow up PR. That way they can just use a Bottom Sheet, which IMO has a better UX. @AndyScherzinger thoughts?

rapterjet2004 avatar Dec 08 '25 15:12 rapterjet2004

Sounds good to me for a follow up but don't think that would be a priority right now. For example getting the sdk bumped to 36 to unblock library updated from being merged would be more important.

I am also fine with the current state since it is already an improvement but leave the review to @mahibi

AndyScherzinger avatar Dec 08 '25 17:12 AndyScherzinger